From dad895d0acd8150d8e2dd2f09b70e601b47eb858 Mon Sep 17 00:00:00 2001 From: ymlam Date: Mon, 3 Dec 2018 05:14:52 +0000 Subject: [PATCH] Do not requeue report as this may lead to a dead lock. It should retry by itself. --- src/altk/comm/engine/postback/PostBack.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/altk/comm/engine/postback/PostBack.java b/src/altk/comm/engine/postback/PostBack.java index 71f9cd7..82e667d 100644 --- a/src/altk/comm/engine/postback/PostBack.java +++ b/src/altk/comm/engine/postback/PostBack.java @@ -142,12 +142,14 @@ public class PostBack break; case SERVER_IO_ERROR: + /* Should not requeue report for this may lead to dead lock on this queu. // TODO: Limit retries, using rate limiting. Posting can be recovered using the activity log. // Re-queue these reports for (String rpt : reportList) { queueReport(rpt); } + */ // Sleep for a while before retrying this PostBack server. CommonLogger.alarm.warn("Caught server IO error. sleep for " + POSTBACK_SERVER_WAIT_TIME + " seconds"); try