From 952d8acb7e8d3ee008215a7cb1702b923d7d09b1 Mon Sep 17 00:00:00 2001 From: ymlam Date: Mon, 10 Jul 2023 02:42:11 -0400 Subject: [PATCH] Relax requirement of launch_record_id in broaddast request. There is no meaningful processing of launch_record_id, which is really just a pass through back to portal. --- src/main/java/altk/comm/engine/Broadcast.java | 6 ------ src/main/java/altk/comm/engine/JobReport.java | 6 +----- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/src/main/java/altk/comm/engine/Broadcast.java b/src/main/java/altk/comm/engine/Broadcast.java index 6b1c807..66a4028 100644 --- a/src/main/java/altk/comm/engine/Broadcast.java +++ b/src/main/java/altk/comm/engine/Broadcast.java @@ -721,12 +721,6 @@ public abstract class Broadcast protected void setLaunchRecordId(String launchRecordId) { - if (launchRecordId == null) - throw new IllegalArgumentException( - "Argument launchRecordId in Broadcast.setLaunchRecordId method cannot be null"); - if (this.launchRecordId != null) - throw new IllegalStateException( - "Broadcast.setLaunchRecordId method cannot be invoked more than once for a Broadcast"); this.launchRecordId = launchRecordId; } diff --git a/src/main/java/altk/comm/engine/JobReport.java b/src/main/java/altk/comm/engine/JobReport.java index 57e4cf7..020e7dc 100644 --- a/src/main/java/altk/comm/engine/JobReport.java +++ b/src/main/java/altk/comm/engine/JobReport.java @@ -23,10 +23,6 @@ public class JobReport { throw new IllegalArgumentException("JobReport given null or empty broadcastId"); } - if (launchRecordId == null || launchRecordId.length() == 0) - { - throw new IllegalArgumentException("JobReport given null or empty launchRecordId"); - } this.broadcastId = broadcastId; this.launchRecordId = launchRecordId; @@ -57,7 +53,7 @@ public class JobReport public final StringBuffer appendXML(StringBuffer xml) { xml.append("<" + xmlRootNodeName + " broadcast_id=\"" + broadcastId - + "\" launch_record_id=\"" + launchRecordId + + (launchRecordId != null? ("\" launch_record_id=\"" + launchRecordId) : "") + "\" " + activityRecordIdParamName + "=\"" + recordId + "\" contact_id=\"" + contactId + "\" recipient_status=\"" + jobStatus + "\" >");