From 73f27cf7f0e3b6ed509a48f4ca9452316c11f2ba Mon Sep 17 00:00:00 2001 From: ymlam Date: Mon, 5 Jun 2017 02:47:33 +0000 Subject: [PATCH] Reverse last change about waiting for postback queue to have space to add a report, as this wait may result in hanging up the process. So an alarm is added to indicate this report is not queued for sending back to portal. --- src/altk/comm/engine/postback/PostBack.java | 27 +++++---------------- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/src/altk/comm/engine/postback/PostBack.java b/src/altk/comm/engine/postback/PostBack.java index e6db23a..ce43757 100644 --- a/src/altk/comm/engine/postback/PostBack.java +++ b/src/altk/comm/engine/postback/PostBack.java @@ -379,29 +379,14 @@ public class PostBack myLogger.debug(myName + ": postQueue size: " + postQueue.size()); synchronized(postQueue) { - for (;;) - { - if (postQueue.size() < maxQueueSize) - { - postQueue.add(report); - postQueue.notify(); - return true; - } - else - { - myLogger.debug("Waiting for space in postQueue to queue report"); - try - { - postQueue.wait(QUEUE_WAIT * 1000); - } - catch (InterruptedException e) - { - break; - } - } + if (postQueue.size() < maxQueueSize) + { + postQueue.add(report); + postQueue.notify(); + return true; } } - myLogger.error("Interrupted while waiting for space to queue report"); + CommonLogger.alarm.warn(myName + ".queueReport failed to send report: " + report); return false; }